Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/4006#issuecomment-71503764
  
    I see. That makes sense. However I still don't see the need for a separate 
`ListenerHelper` trait. In my mind `SparkListenerBus` should extend 
`ListenerBus[L, E]` instead of `ListenerHelper` directly. If that's the case, 
then the only class that's actually implementing `ListenerHelper` will be 
`ListenerBus`, at which point you can just merge the trait with the class 
itself. Is there a reason for keeping around the trait?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to