srowen commented on a change in pull request #25673: [SPARK-28770][CORE][TEST]
Fix ReplayListenerSuite tests that sometime…
URL: https://github.com/apache/spark/pull/25673#discussion_r321268264
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/ReplayListenerSuite.scala
##########
@@ -236,20 +238,15 @@ class ReplayListenerSuite extends SparkFunSuite with
BeforeAndAfter with LocalSp
/**
* A simple listener that buffers all the events it receives.
*
- * The event buffering functionality must be implemented within
EventLoggingListener itself.
- * This is because of the following race condition: the event may be mutated
between being
- * processed by one listener and being processed by another. Thus, in order
to establish
- * a fair comparison between the original events and the replayed events,
both functionalities
- * must be implemented within one listener (i.e. the EventLoggingListener).
- *
- * This child listener inherits only the event buffering functionality, but
does not actually
- * log the events.
*/
- private class EventMonster(conf: SparkConf)
- extends EventLoggingListener("test", None, new URI("testdir"), conf) {
+ private class EventMonster extends SparkFirehoseListener {
Review comment:
No need to change it here, but, Event_Monster_?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
