srowen commented on a change in pull request #25690: [test-hadoop3.2] Revert
"[SPARK-27831][SQL][TEST] Move Hive test jars to maven dependency"
URL: https://github.com/apache/spark/pull/25690#discussion_r321273812
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -202,7 +201,10 @@ class CliSuite extends SparkFunSuite with
BeforeAndAfterAll with Logging {
}
test("Commands using SerDe provided in --jars") {
- val jarFile = HiveTestUtils.getHiveHcatalogCoreJar.getCanonicalPath
+ val jarFile = "../hive/src/test/resources/" +
Review comment:
Adding these JARs to the source tree has some LICENSE and NOTICE
implications. The Hive NOTICE text from these JARs would have to go in NOTICE
(and probably NOTICE-binary as we published test JARs). They'd have to be
listed in LICENSE and LICENSE-binary too.
This is possible, but is it equally possible to just download these like we
do with other Hive jars?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
