maryannxue commented on a change in pull request #25644: [SPARK-28940][SQL]
Subquery reuse across all subquery levels
URL: https://github.com/apache/spark/pull/25644#discussion_r321310152
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1238,7 +1238,10 @@ class DynamicPartitionPruningSuite
val plan = df.queryExecution.executedPlan
val countSubqueryBroadcasts =
- plan.collectInPlanAndSubqueries({ case _: SubqueryBroadcastExec => 1
}).sum
+ plan.collectInPlanAndSubqueries({
Review comment:
Nit: you could also do
```
val countSubqueryBroadcasts =
plan.collectInPlanAndSubqueries({ case _: SubqueryBroadcastExec => 1
}).sum
val countReusedSubqueryBroadcasts =
plan.collectInPlanAndSubqueries({
case ReusedSubqueryExec(_: SubqueryBroadcastExec) => 1
}).sum
assert(countSubqueryBroadcasts == 1)
assert(countReusedSubqueryBroadcasts == 1)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
