Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4205#discussion_r23555762
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/api/java/JavaVertexRDDLike.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.graphx.api.java
+
+import java.util.{List => JList}
+
+import org.apache.spark.api.java.JavaRDDLike
+import org.apache.spark.api.java.function.{Function => JFunction,
Function2 => JFunction2, Function3 => JFunction3}
+import org.apache.spark.graphx._
+import org.apache.spark.graphx.impl.{EdgeRDDImpl, ShippableVertexPartition}
+import org.apache.spark.rdd.RDD
+import org.apache.spark.{Logging, Partition, TaskContext}
+
+import scala.language.implicitConversions
+import scala.reflect.ClassTag
+
+trait JavaVertexRDDLike[VD, This <: JavaVertexRDDLike[VD, This, R],
--- End diff --
What do you mean by "handle type bounds"? In this PR's current code, it
looks like `JavaVertexRDDLike` is only extended by a single class and isn't
used as part of any method signatures, return types, etc, so unless I'm
overlooking something I don't see why it can't be removed. Inheriting
implementations from generic traits has bitten us in the past via
https://issues.scala-lang.org/browse/SI-8905 (see
https://issues.apache.org/jira/browse/SPARK-3266), so if this trait isn't
necessary then we shouldn't have it.
The JavaRDDLike traits in the Spark Core Java API are an unfortunate
holdover from an earlier design and exists primarily for code re-use purposes.
We can't remove it now due because that would break binary compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
