HeartSaVioR commented on a change in pull request #25705: SPARK-29003: Spark
history server startup hang due to deadlock
URL: https://github.com/apache/spark/pull/25705#discussion_r321558542
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala
##########
@@ -151,6 +151,7 @@ class HistoryServer(
/** Bind to the HTTP server behind this web interface. */
override def bind() {
super.bind()
+ provider.start()
Review comment:
I'd rather place `provider.start()` after `server.bind()` in `main()`, not
here. It feels really odd to start provider when calling bind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
