xuanyuanking commented on a change in pull request #25620: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/25620#discussion_r321561344
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1047,6 +1047,14 @@ package object config {
.checkValue(v => v > 0, "The value should be a positive integer.")
.createWithDefault(2000)
+ private[spark] val SHUFFLE_USE_OLD_FETCH_PROTOCOL =
Review comment:
```
What happens if you connect to an old shuffle service without setting this?
Will things just fail (and always fail)?
```
We'll always fail with the UnsupportedOperationException:`Unexpected
message: FetchShuffleBlocks`. This work is done in #24565.
```
Although a more user-friendly error, if possible, might be good.
```
Yeah, in this PR we had detailed log in DAGScheduler.
Let me think how to add a more user-friendly error in the follow-up work for
the old shuffle service, currently, we only have some doc in the migration
guide.
https://github.com/apache/spark/pull/24565/files#diff-3f19ec3d15dcd8cd42bb25dde1c5c1a9R139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
