Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4205#discussion_r23556688
--- Diff: python/pyspark/graphx/graph.py ---
@@ -0,0 +1,169 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""
+Python bindings for Graph[VertexRDD, EdgeRDD] in GraphX
+"""
+
+import itertools
+from pyspark import PickleSerializer, RDD, StorageLevel, SparkContext
+from pyspark.graphx import VertexRDD, EdgeRDD
+
+from pyspark.graphx.partitionstrategy import PartitionStrategy
+from pyspark.rdd import PipelinedRDD
+from pyspark.serializers import BatchedSerializer
+
+__all__ = ["Graph"]
+
+class Graph(object):
+ def __init__(self, vertex_jrdd, edge_jrdd,
+ partition_strategy=PartitionStrategy.EdgePartition1D):
+ self._vertex_jrdd = VertexRDD(vertex_jrdd, vertex_jrdd.context,
+
BatchedSerializer(PickleSerializer()))
+ self._edge_jrdd = EdgeRDD(edge_jrdd, edge_jrdd.context,
+ BatchedSerializer(PickleSerializer()))
+ self._partition_strategy = partition_strategy
+ self._jsc = vertex_jrdd.context
+
+ def persist(self, storageLevel):
+ self._vertex_jrdd.persist(storageLevel)
+ self._edge_jrdd.persist(storageLevel)
+ return
+
+ def cache(self):
+ self._vertex_jrdd.cache()
+ self._edge_jrdd.cache()
+ return
+
+ def vertices(self):
+ return self._vertex_jrdd
+
+ def edges(self):
+ return self._edge_jrdd
+
+ def numEdges(self):
+ return self._edge_jrdd.count()
+
+ def numVertices(self):
+ return self._vertex_jrdd.count()
+
+ # TODO
+ def partitionBy(self, partitionStrategy):
--- End diff --
For these `TODO`s, if they don't land in the first version then we should
comment out the methods as well. I think we should keep the TODOs as a
reminder of what's missing, but shouldn't have empty methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
