turboFei commented on issue #25701: [SPARK-29000][SQL] Decimal precision overflow when don't allow precision loss URL: https://github.com/apache/spark/pull/25701#issuecomment-528766643 Yes, I think we should skip to handle decimals in ImplictTypeCasts too. I wanted reuse all the logic in nondecimalAndDecimal method originally. However, do you think the operation that cast decimal to double will loss precision? https://github.com/apache/spark/blob/4664a082c2c7ac989e818958c465c72833d3ccfe/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala#L326-L329
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
