srowen commented on a change in pull request #25684:
[SPARK-28980][CORE][SQL][STREAMING][MLLIB] Remove most items deprecated in
Spark 2.2.0 or earlier, for Spark 3
URL: https://github.com/apache/spark/pull/25684#discussion_r321736686
##########
File path: R/pkg/NAMESPACE
##########
@@ -387,8 +387,6 @@ exportMethods("%<=>%",
"sumDistinct",
"tan",
"tanh",
- "toDegrees",
Review comment:
Yep I see the argument @felixcheung . I reopened it because we have a
similar situation with `SQLContext.createExternalTable`, which was deprecated
everywhere but Pyspark. Presumably it was also just an oversight. Looks like
we're going to remove that. I'd moderately prefer to remove these for
consistency, both in the decision and w.r.t. the `toDegrees` method. Is that
persuasive? If you feel fairly strongly about keeping it deprecated, that's OK
and I can revert this part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
