HeartSaVioR commented on a change in pull request #25706:
[SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully
processed before checking recorded values
URL: https://github.com/apache/spark/pull/25706#discussion_r321926106
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -1141,7 +1169,7 @@ class DAGSchedulerSuite extends SparkFunSuite with
LocalSparkContext with TimeLi
taskSets(0).tasks(1),
TaskKilled("test"),
null))
- assert(failedStages === Seq(0))
+ assert(sparkListener.failedStages === Seq(0))
Review comment:
This is actual place of bug. The code is newly added (for "newly" I meant
after the pattern of `sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS)` is
applied) and doesn't follow the existing pattern. That is easily missed and
here we can enforce it by disallowing access variables directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
