HeartSaVioR commented on issue #25709: [SPARK-29007][STREAMING][MLLIB] Enforce not leaking SparkContext in tests which creates new StreamingContext with new SparkContext URL: https://github.com/apache/spark/pull/25709#issuecomment-529048642 Thanks both of you for the valuable feedbacks! I agree trait would be better to not forget and blindly apply to test suites. I'll try to reflect the change. Personally I'd in favor of try-with-resource-like patterns (withXXXContext methods are similar) so if I need to make a change I'd hope to apply this, but if the test suite already has a field for (Streaming/Spark)Context and cleanup with this, I won't change the approach.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
