MaxGekk commented on a change in pull request #25708: [SPARK-28141][SQL]
Support special date values
URL: https://github.com/apache/spark/pull/25708#discussion_r321977240
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -17,24 +17,30 @@
package org.apache.spark.sql.catalyst.util
-import java.time.LocalDate
+import java.time.{LocalDate, ZoneId}
import java.util.Locale
+import DateTimeUtils._
+
sealed trait DateFormatter extends Serializable {
def parse(s: String): Int // returns days since epoch
def format(days: Int): String
}
class Iso8601DateFormatter(
pattern: String,
+ zoneId: ZoneId,
locale: Locale) extends DateFormatter with DateTimeFormatterHelper {
@transient
private lazy val formatter = getOrCreateFormatter(pattern, locale)
override def parse(s: String): Int = {
- val localDate = LocalDate.parse(s, formatter)
- DateTimeUtils.localDateToDays(localDate)
+ val specialDate = convertSpecialDate(s.trim, zoneId)
Review comment:
We always trim input inside of `stringToDate`. Maybe here we should trim the
input in all cases? /cc @HyukjinKwon @srowen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
