HyukjinKwon commented on a change in pull request #25655: [SPARK-28906][Build] 
Fix incorrect information in bin/spark-submit --version
URL: https://github.com/apache/spark/pull/25655#discussion_r321989561
 
 

 ##########
 File path: dev/create-release/release-build.sh
 ##########
 @@ -179,7 +178,7 @@ if [[ "$1" == "package" ]]; then
     rm -r spark-$SPARK_VERSION/licenses-binary
   fi
 
-  tar cvzf spark-$SPARK_VERSION.tgz spark-$SPARK_VERSION
+  tar cvzf spark-$SPARK_VERSION.tgz --exclude spark-$SPARK_VERSION/.git 
spark-$SPARK_VERSION
 
 Review comment:
   I think it's supposed to be ran for both SBT and Maven builds:
   
   ```
   core/pom.xml:                  <arg 
value="${project.basedir}/../build/spark-build-info"/>
   project/SparkBuild.scala:      val buildScript = baseDirectory.value + 
"/../build/spark-build-info"
   ```
   
   I think @viirya meant we might better consider fixing somewhere around 
`build/spark-build-info` script.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to