maropu commented on issue #25707: [SPARK-28587][SQL] Explicitly cast JDBC partition string literals to timestamp/date URL: https://github.com/apache/spark/pull/25707#issuecomment-529170748 @HyukjinKwon @MaxGekk Thanks for the check, guys! > Currently it could work with target column type STRING, probably. With this PR, we require to support particular type TIMESTAMP by user's DBMS. I would guess this can potentially break user's apps if the remote column has different type but DMBS is able to convert values from strings. Ur, it looks a nice suggestion... I saw this comment then I re-checked the type name for timestamps in the other databases; https://www.w3resource.com/sql/data-type.php#DATETIME I was thinking the type name for timestamps is specified by the standard, but it seems this is not correct? In some SQL servers, the name is not `TIMESTAMP` but `DATETIME`.... I need more time to consider how to fix it. > Will it work (and how well) if target column type TIMESTAMPTZ (TIMESTAMP WITH TIMEZONE). Currently, the type is implicitly converted from STRING to TIMESTAMPTZ as you mentioned in the description but with the changes STRING -> TIMESTAMP -> TIMESTAMPTZ. I see. But, does the behaviour difference between `string->timestamp->timestampz`/`string->timestampz` causes actual user-facing issues?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
