felixcheung commented on a change in pull request #24939: [SPARK-18569][ML][R]
Support RFormula arithmetic, I() and spark functions
URL: https://github.com/apache/spark/pull/24939#discussion_r322032270
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
##########
@@ -404,6 +429,30 @@ class RFormulaModel private[feature](
s"Label column already exists and is not of type
${NumericType.simpleString}.")
}
+ private def foldExprs(dataframe: DataFrame)(f: (DataFrame, String) =>
DataFrame): DataFrame =
+ resolvedFormula.evalExprs.foldLeft(dataframe)(f)
Review comment:
I mean instead of calling this as a method twice, save the return into a
local variable and re-use it (and maybe we don't need a method then)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
