hddong commented on a change in pull request #25389: [SPARK-28657][CORE] Fix
currentContext Instance failed sometimes
URL: https://github.com/apache/spark/pull/25389#discussion_r322042709
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2991,7 +2991,7 @@ private[spark] class CallerContext(
if (CallerContext.callerContextSupported) {
try {
val callerContext =
Utils.classForName("org.apache.hadoop.ipc.CallerContext")
- val builder =
Utils.classForName("org.apache.hadoop.ipc.CallerContext$Builder")
+ val builder: Class[_] =
Utils.classForName("org.apache.hadoop.ipc.CallerContext$Builder")
Review comment:
> Hm OK that makes more sense. Ideally we'd use
`Class.forName[CallerContext$Builder]` here, but I presume we can't actually
directly use the class. The change is fine. You could use `Class[AnyRef]` I
think to be a little more precise, but it won't matter much.
Yep, `Builder` can't be used here and `Class[AnyRef]` is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
