HyukjinKwon commented on a change in pull request #25172: [SPARK-28412][SQL] 
ANSI SQL: OVERLAY function support byte array
URL: https://github.com/apache/spark/pull/25172#discussion_r322123822
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
 ##########
 @@ -496,19 +509,42 @@ case class Overlay(input: Expression, replace: 
Expression, pos: Expression, len:
     this(str, replace, pos, Literal.create(-1, IntegerType))
 
 Review comment:
   I meant to add an example for this function under 502 lines. Since SparkSQL 
doesn't support binary literal you can use `bin` function in the example.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to