jinxingwang commented on a change in pull request #25614: [SPARK-28887][K8S]
Executor pod status fix
URL: https://github.com/apache/spark/pull/25614#discussion_r322346814
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshot.scala
##########
@@ -59,7 +61,24 @@ object ExecutorPodsSnapshot extends Logging {
case "pending" =>
PodPending(pod)
case "running" =>
- PodRunning(pod)
+ // TODO: upcoming Kubernenetes feature will make this code redundant
+ // https://github.com/kubernetes/enhancements/issues/753
+ // Checking executor container status is not terminated
+ // Pod status can still be running if sidecar container status is
running
+ val executorContainerStatusCode =
pod.getStatus.getContainerStatuses.asScala.
+ filter(_.getName == DEFAULT_EXECUTOR_CONTAINER_NAME).
Review comment:
I think you made a really good point, but as far as I know, there is no
identifier of container expect the container name. maybe we have to force
people use this default name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
