HeartSaVioR edited a comment on issue #25696: [SPARK-28996][SQL] Add tests regarding username of HiveClient URL: https://github.com/apache/spark/pull/25696#issuecomment-529607601 There're some reasons to make this be separated PR: 1. I suggested adding UT in #23952 before, and the author didn't follow the suggestion so I had to put my own effort to deal with this. If I needed to raise the PR against author's fork, I should also persuade to merge it to reflect the PR, which seems to be unnecessary effort (and in my personal experience it has been progressed slowly on coordinating with other contributors... I've been also waiting for other contributor in #25577 to coordinate). If this patch got merged before, #23952 will make new tests be broken so #23952 is forced to apply the change. If this patch got merged after, I'm open to apply the change. 2. This patch can be independent with #23952, as the new tests are passing with current behavior. This patch is still valuable without #23952 as we should have to have tests to prevent changing behavior unintentionally. We didn't notice the behavioral change in latest change of [SPARK-22846](http://issues.apache.org/jira/browse/SPARK-22846) - we thought it fixed NPE but it also changed the behavior. This is a non-trivial issue. 3. Minor, but authorship issue. IMHO I'm not sure who is the right main author of merged PR, as I expect there's similar amount of effort being put between #23952 and this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
