Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3962#discussion_r23581653
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
@@ -231,6 +231,25 @@ private[spark] class ApplicationMaster(args:
ApplicationMasterArguments,
reporterThread = launchReporterThread()
}
+ /**
+ * Creates an actor that ApplicationMaster communicates with
YarnScheduler of driver
+ * in Yarn deploy mode.
+ *
+ * If isDriver is set to true, AMActor and driver belong to same process.
+ * so AMActor don't monitor lifecycle of driver.
+ */
+ private def runAMActor(
+ host: String,
+ port: String,
+ isDriver: Boolean): Unit = {
--- End diff --
we need to consider again. because isDriver in here consistent with
ApplicationMaster's variable "isDriver". if we rename isDriver to isClusterMode
in here, maybe we need to rename all isDriver in ApplicationMaster. so i think
we should keep isDriver.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
