HyukjinKwon commented on a change in pull request #25740:
[SPARK-28412][SQL][TEST][FOLLOW-UP]Enable overlay binary function tests
URL: https://github.com/apache/spark/pull/25740#discussion_r322544935
##########
File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/strings.sql
##########
@@ -653,8 +653,9 @@ SELECT trim(binary('\\000') from binary('\\000Tom\\000'));
-- SELECT btrim(E'\\000trim\\000'::bytea, ''::bytea);
-- [SPARK-28121] decode can not accept 'escape' as charset
-- [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array
--- SELECT encode(overlay(E'Th\\000omas'::bytea placing E'Th\\001omas'::bytea
from 2),'escape');
--- SELECT encode(overlay(E'Th\\000omas'::bytea placing E'\\002\\003'::bytea
from 8),'escape');
--- SELECT encode(overlay(E'Th\\000omas'::bytea placing E'\\002\\003'::bytea
from 5 for 3),'escape');
Review comment:
Why the tests are different? Those tests were ported from PostgresSQL's so
we should better keep it consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
