Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3200#discussion_r23582372
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.mllib.linalg.distributed
+
+import breeze.linalg.{DenseMatrix => BDM}
+
+import org.apache.spark.{Logging, Partitioner}
+import org.apache.spark.mllib.linalg._
+import org.apache.spark.mllib.rdd.RDDFunctions._
+import org.apache.spark.rdd.RDD
+import org.apache.spark.storage.StorageLevel
+
+/**
+ * A grid partitioner, which stores every block in a separate partition.
+ *
+ * @param numRowBlocks Number of blocks that form the rows of the matrix.
+ * @param numColBlocks Number of blocks that form the columns of the
matrix.
+ */
+private[mllib] class GridPartitioner(
+ val numRowBlocks: Int,
+ val numColBlocks: Int,
+ val numParts: Int) extends Partitioner {
+ // Having the number of partitions greater than the number of sub
matrices does not help
+ override val numPartitions = math.min(numParts, numRowBlocks *
numColBlocks)
+
+ /**
+ * Returns the index of the partition the SubMatrix belongs to. Tries to
achieve block wise
+ * partitioning.
+ *
+ * @param key The key for the SubMatrix. Can be its position in the grid
(its column major index)
+ * or a tuple of three integers that are the final row index
after the multiplication,
+ * the index of the block to multiply with, and the final
column index after the
+ * multiplication.
+ * @return The index of the partition, which the SubMatrix belongs to.
+ */
+ override def getPartition(key: Any): Int = {
+ key match {
+ case (blockRowIndex: Int, blockColIndex: Int) =>
+ getBlockId(blockRowIndex, blockColIndex)
+ case (blockRowIndex: Int, innerIndex: Int, blockColIndex: Int) =>
+ getBlockId(blockRowIndex, blockColIndex)
+ case _ =>
+ throw new IllegalArgumentException(s"Unrecognized key. key: $key")
+ }
+ }
+
+ /** Partitions sub-matrices as blocks with neighboring sub-matrices. */
+ private def getBlockId(blockRowIndex: Int, blockColIndex: Int): Int = {
--- End diff --
Should it be called `getPartition` or `getPartitionId`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
