maropu commented on a change in pull request #25464: [SPARK-28746][SQL] Add
partitionby hint for sql queries
URL: https://github.com/apache/spark/pull/25464#discussion_r322571702
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1307,7 +1308,16 @@ class Dataset[T] private[sql](
*/
@scala.annotation.varargs
def hint(name: String, parameters: Any*): Dataset[T] = withTypedPlan {
- UnresolvedHint(name, parameters, logicalPlan)
+ if (ResolveHints.ResolveCoalesceHints.COALESCE_HINT_NAMES.contains(
Review comment:
Ur, I see.... I feel a bit weird handling here... we might be better to give
up some representations (e.g., `hint("repartition", 1, df("a"))`,
`hint("repartition", 1, $"a")`, ....) so as to simplify the implementation. cc:
@maryannxue @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
