srowen commented on a change in pull request #25741: [WIP][SPARK-29032][CORE]
Simplify Prometheus support by adding PrometheusServlet
URL: https://github.com/apache/spark/pull/25741#discussion_r322755447
##########
File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
##########
@@ -201,6 +203,12 @@ private[spark] class MetricsSystem private (
classOf[Properties], classOf[MetricRegistry],
classOf[SecurityManager])
.newInstance(kv._2, registry, securityMgr)
metricsServlet = Some(servlet)
+ } else if (kv._1 == "prometheusServlet") {
Review comment:
If you want you can make `kv` into `case (key, value)` here for clarity, but
not necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
