MaxGekk commented on issue #25678: [SPARK-28973][SQL] Add `TimeType` and support `java.time.LocalTime` as its external type. URL: https://github.com/apache/spark/pull/25678#issuecomment-530024672 > does ParquetSchemaConverter need a new case to handle the new type then? to and from Parquet? or is it already handled. We will need to support new type in all data sources. In particular, `ParquetSchemaConverter` must have special case for `TIME`. > Likewise, just trying to figure out how for example our JDBC support translates this type, for an RDBMS that does support TIME, because I don't see any change to the JDBC support. In this PR, I just introduce new type and its external type. To support it by the `JDBC` data source, need to add separate cases to `JdbcUtils` like https://github.com/apache/spark/blob/868e02533d76d45bff4200d07658105b6004cf46/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L567-L569 and https://github.com/apache/spark/blob/868e02533d76d45bff4200d07658105b6004cf46/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L178
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
