maryannxue commented on a change in pull request #25569: [SPARK-28863][SQL]
Introduce AlreadyPlanned, a node that speeds-up planning
URL: https://github.com/apache/spark/pull/25569#discussion_r322987005
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -632,6 +632,7 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
object BasicOperators extends Strategy {
def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
+ case AlreadyPlanned(physical, output) => AlreadyPlannedExec(physical,
output) :: Nil
Review comment:
So we should make sure the "already planned" `SparkPlan` comes from
`sparkPlan` not `executedPlan`, right? @hvanhovell
And indeed some physical preparation rules are not idempotent, WSCG being
one of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
