vanzin commented on a change in pull request #25709:
[SPARK-29007][STREAMING][MLLIB][TESTS] Enforce not leaking SparkContext in
tests which creates new StreamingContext with new SparkContext
URL: https://github.com/apache/spark/pull/25709#discussion_r323012821
##########
File path:
streaming/src/test/scala/org/apache/spark/streaming/DStreamScopeSuite.scala
##########
@@ -30,28 +30,23 @@ import org.apache.spark.util.ManualClock
/**
* Tests whether scope information is passed from DStream operations to RDDs
correctly.
*/
-class DStreamScopeSuite extends SparkFunSuite with BeforeAndAfter with
BeforeAndAfterAll {
- private var ssc: StreamingContext = null
- private val batchDuration: Duration = Seconds(1)
+class DStreamScopeSuite
+ extends SparkFunSuite
+ with LocalStreamingContext
+ with BeforeAndAfter
+ with BeforeAndAfterAll {
Review comment:
BeforeAndAfterAll doesn't seem to be used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
