shanyu commented on issue #25705: [SPARK-29003][CORE] Fix deadlock in startup of Spark History Server URL: https://github.com/apache/spark/pull/25705#issuecomment-530189306 Thank you @HeartSaVioR! I have added the provider.start() to HistoryServerSuite, it is in my PR. I didn't add them to FsHistoryProvider because I see no need to, as you mentioned already. The test suite knows the implementation so it does not have to follow the start/stop pattern. For one thing the tests didn't call stop(). If we are to modify the implementation of FsHistoryProvider.start() we can add start() at that point.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
