dongjinleekr commented on a change in pull request #22282: [SPARK-23539][SS]
Add support for Kafka headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#discussion_r323045234
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -369,17 +371,36 @@ class KafkaTestUtils(
topic: String,
messages: Array[String],
partition: Option[Int]): Seq[(String, RecordMetadata)] = {
+ sendMessages(topic, messages.map(m => (m, Seq())), partition)
+ }
+
+ /** Send record to the Kafka broker with headers using specified partition */
+ def sendMessage(topic: String,
+ record: (String, Seq[(String, Array[Byte])]),
+ partition: Option[Int]): Seq[(String, RecordMetadata)] = {
+ sendMessages(topic, Array(record).toSeq, partition)
+ }
+
+ /** Send the array of records to the Kafka broker with headers using
specified partition */
+ def sendMessages(topic: String,
+ records: Seq[(String, Seq[(String, Array[Byte])])],
+ partition: Option[Int]): Seq[(String, RecordMetadata)] = {
producer = new KafkaProducer[String, String](producerConfiguration)
val offsets = try {
- messages.map { m =>
+ records.map { case (value, header) =>
+ val headers = header.map { case (k, v) =>
+ new RecordHeader(k, v).asInstanceOf[Header]
+ }
val record = partition match {
- case Some(p) => new ProducerRecord[String, String](topic, p, null, m)
- case None => new ProducerRecord[String, String](topic, m)
+ case Some(p) =>
+ new ProducerRecord[String, String](topic, p, null, value,
headers.asJava)
Review comment:
We can't; `Option#orNull` returns scala `Null` type, not java `null`.
Because of that, the compiler can't resolve the appropriate constructor then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
