gengliangwang commented on a change in pull request #25723:
[SPARK-29019][WebUI] Improve tooltip JDBC/ODBC Server tab
URL: https://github.com/apache/spark/pull/25723#discussion_r323057115
##########
File path: core/src/main/scala/org/apache/spark/ui/UIUtils.scala
##########
@@ -311,7 +311,9 @@ private[spark] object UIUtils extends Logging {
id: Option[String] = None,
headerClasses: Seq[String] = Seq.empty,
stripeRowsWithCss: Boolean = true,
- sortable: Boolean = true): Seq[Node] = {
+ sortable: Boolean = true,
+ // The tooltip information could be None, which indicates header does
not have a tooltip.
+ tooltipHeaders: Seq[Option[String]] = Seq.empty): Seq[Node] = {
Review comment:
I see. My concern was the length of `tooltipHeaders` can be different with
`headers`. Passing parameter `Seq[Option[String]]` seems equivalent to
`Map[Int, String]`.
I am fine with either way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
