cloud-fan commented on a change in pull request #25754: [WIP][SPARK-29048] Improve performance on Column.isInCollection() with a large size collection URL: https://github.com/apache/spark/pull/25754#discussion_r323134341
########## File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ########## @@ -808,7 +809,14 @@ class Column(val expr: Expression) extends Logging { * @group expr_ops * @since 2.4.0 */ - def isInCollection(values: scala.collection.Iterable[_]): Column = isin(values.toSeq: _*) + def isInCollection(values: scala.collection.Iterable[_]): Column = withExpr { + val hSet = values.toSet[Any] Review comment: we always create the set to deduplicate the values? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org