HeartSaVioR commented on a change in pull request #25702: [SPARK-29001][CORE]
Print events that take too long time to process
URL: https://github.com/apache/spark/pull/25702#discussion_r323216331
##########
File path: core/src/main/scala/org/apache/spark/util/ListenerBus.scala
##########
@@ -37,6 +38,12 @@ private[spark] trait ListenerBus[L <: AnyRef, E] extends
Logging {
// Marked `private[spark]` for access in tests.
private[spark] def listeners = listenersPlusTimers.asScala.map(_._1).asJava
+ private lazy val logSlowEventEnabled =
Review comment:
SparkEnv may not be always available, especially for test suites. The test
failures in CI builds comes from NPE, as NPE occurs here, and NPE gets
propagated and finally kills the dispatch thread for AsyncEventQueue.
So we might want to set default value if SparkEnv is not available, or have
some method for descendants to provide SparkConf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
