planga82 commented on a change in pull request #25723: [SPARK-29019][WebUI]
Improve tooltip JDBC/ODBC Server tab
URL: https://github.com/apache/spark/pull/25723#discussion_r323336051
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
##########
@@ -72,6 +72,9 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab)
extends WebUIPage(""
val table = if (numStatement > 0) {
val headerRow = Seq("User", "JobID", "GroupID", "Start Time", "Finish
Time", "Close Time",
"Execution Time", "Duration", "Statement", "State", "Detail")
+ val tooltips = Seq(None, None, None, None,
Some(ToolTips.THRIFT_SERVER_FINISH_TIME),
+ Some(ToolTips.THRIFT_SERVER_CLOSE_TIME),
Some(ToolTips.THRIFT_SERVER_EXECUTION),
+ Some(ToolTips.THRIFT_SERVER_DURATION), None, None, None)
Review comment:
I've been thinking about it, yes, it's a good idea, in that way we don't
break the homogeneous way of treating the parameters at _UIUtils.listingTable_
and we ensure it is going to be less problems if new headers are added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
