juliuszsompolski commented on a change in pull request #25762: [SPARK-29056]
ThriftServerSessionPage displays 1970/01/01 finish and close time when unset
URL: https://github.com/apache/spark/pull/25762#discussion_r323351232
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
##########
@@ -98,8 +98,8 @@ private[ui] class ThriftServerSessionPage(parent:
ThriftServerTab)
</td>
<td>{info.groupId}</td>
<td>{formatDate(info.startTimestamp)}</td>
- <td>{formatDate(info.finishTimestamp)}</td>
- <td>{formatDate(info.closeTimestamp)}</td>
+ <td>{if (info.finishTimestamp > 0)
formatDate(info.finishTimestamp)}</td>
+ <td>{if (info.closeTimestamp > 0)
formatDate(info.closeTimestamp)}</td>
<td>{formatDurationOption(Some(info.totalTime(info.finishTimestamp)))}</td>
Review comment:
No, `info.totalTime` will return `System.currentTimeMillis - startTimestamp`
if finishTimestamp / closeTimestamp is not set, and that is going to be
displayed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
