vanzin commented on a change in pull request #25753: [SPARK-29046][SQL] Fix NPE
in SQLConf.get when active SparkContext is stopping
URL: https://github.com/apache/spark/pull/25753#discussion_r323378348
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -139,7 +139,8 @@ object SQLConf {
}
} else {
val isSchedulerEventLoopThread = SparkContext.getActive
- .map(_.dagScheduler.eventProcessLoop.eventThread)
+ .flatMap(sc => Option(sc.dagScheduler))
Review comment:
nit: we use `{ sc => ... }` for closures. Also later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
