HeartSaVioR commented on a change in pull request #23952: [SPARK-26929][SQL]fix 
table owner use user instead of principal when create table through spark-sql 
or beeline
URL: https://github.com/apache/spark/pull/23952#discussion_r323457041
 
 

 ##########
 File path: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
 ##########
 @@ -220,7 +221,15 @@ private[hive] class HiveClientImpl(
     hiveConf
   }
 
-  private val userName = conf.getUser
+  private val userName = {
+    val doAs = sys.env.get("HADOOP_USER_NAME").orNull
+    val ugi = if (doAs != null && doAs.length() > 0) {
 
 Review comment:
   Yeah actually I just read decompiled code of `Utils.getUGI()` and didn't 
indicate the intention - let other application be able to pass it. Yes I agree 
it's not needed in Spark side, and it would be weird `HADOOP_USER_NAME` is only 
used here and undocumented. Thanks for explaining!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to