brkyvz commented on a change in pull request #25700: [SPARK-28998][SQL] reorganize the packages of DS v2 interfaces/classes URL: https://github.com/apache/spark/pull/25700#discussion_r323457661
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala ########## @@ -27,6 +27,7 @@ import org.apache.spark.sql.internal.SQLConf * A thread-safe manager for [[CatalogPlugin]]s. It tracks all the registered catalogs, and allow * the caller to look up a catalog by name. */ +private[sql] Review comment: do we not want to make this API public, similar to the catalog implementation we had before? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
