dongjoon-hyun commented on a change in pull request #25769: [SPARK-29032][CORE] Add PrometheusServlet to monitor Masster/Worker/Driver URL: https://github.com/apache/spark/pull/25769#discussion_r323550125
########## File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala ########## @@ -201,6 +203,12 @@ private[spark] class MetricsSystem private ( classOf[Properties], classOf[MetricRegistry], classOf[SecurityManager]) .newInstance(kv._2, registry, securityMgr) metricsServlet = Some(servlet) + } else if (kv._1 == "prometheusServlet") { Review comment: For this, I'll keep the current form instead of `case`, @srowen ~ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org