imback82 commented on a change in pull request #25771: [SPARK-28970][SQL]
Implement USE CATALOG/NAMESPACE for Data Source V2
URL: https://github.com/apache/spark/pull/25771#discussion_r323555674
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
##########
@@ -188,18 +186,10 @@ case class DataSourceResolution(
}
case ShowTablesStatement(None, pattern) =>
- defaultCatalog match {
- case Some(catalog) =>
- ShowTables(
- catalog.asTableCatalog,
- catalogManager.currentNamespace,
- pattern)
- case None =>
- ShowTablesCommand(None, pattern)
- }
+ ShowTables(currentCatalog.asTableCatalog,
catalogManager.currentNamespace, pattern)
Review comment:
If there is no catalog specified, this will not fallback to v1 anymore since
`currentCatalog` always returns a `CatalogPlugin`. This should be OK right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
