maropu commented on issue #25772: [SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark URL: https://github.com/apache/spark/pull/25772#issuecomment-530700815 Ur, I see. I didn't notice we've already accepted explicit casts from long to timestamp though, any reason to support this explicit cast? It seems pgSQL doesn't accept that ; ``` postgres=# select cast(0::bigint as timestamp); ERROR: cannot cast type bigint to timestamp without time zone LINE 1: select cast(0::bigint as timestamp); ^ postgres=# select cast(0::int as date); ERROR: cannot cast type integer to date LINE 1: select cast(0::int as date); ^ ``` cc: @gengliangwang
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org