maropu commented on a change in pull request #25766: [SPARK-29061][SQL] Prints
bytecode statistics in debugCodegen
URL: https://github.com/apache/spark/pull/25766#discussion_r323607611
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -1353,19 +1370,17 @@ object CodeGenerator extends Logging {
byteCodeSize
}
}
- Some(stats)
+ (classCodeSize, methodCodeSizes.max, constPoolSize)
Review comment:
No strong reason... I just did because I avoided the longer statement in
https://github.com/apache/spark/pull/25766/files#diff-8bcc5aea39c73d4bf38aef6f6951d42cR1382;
```
ByteCodeStats(codeStats.reduce { case (v1, v2) =>
(Math.max(v1.maxClassCodeSize, v2.maxClassCodeSize),
Math.max(v1.maxMethodCodeSize, v2.maxMethodCodeSize),
Math.max(v1.maxConstPoolSize, v2.maxConstPoolSize))
})
```
If there are other reviewers who like that, I'll update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
