rednaxelafx commented on a change in pull request #25766: [SPARK-29061][SQL]
Prints bytecode statistics in debugCodegen
URL: https://github.com/apache/spark/pull/25766#discussion_r323610161
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -1353,19 +1370,17 @@ object CodeGenerator extends Logging {
byteCodeSize
}
}
- Some(stats)
+ (classCodeSize, methodCodeSizes.max, constPoolSize)
Review comment:
I find named fields much more readable than _1 _2 _3. In fact even with
tuples I may have written the code like:
```scala
ByteCodeStats(codeStats.reduce { case ((maxClassCodeSize1,
maxMethodCodeSize1, maxConstPoolSize), (maxClassCodeSize2, maxMethodCodeSize2,
maxConstPoolSize2)) =>
(Math.max(maxClassCodeSize1, maxClassCodeSize2),
Math.max(maxMethodCodeSize1, maxMethodCodeSize2),
Math.max(maxConstPoolSize1, maxConstPoolSize2))
})
```
and...I'd say the `v1.maxClassCodeSize` version looks better here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
