kiszk commented on a change in pull request #25766: [SPARK-29061][SQL] Prints
bytecode statistics in debugCodegen
URL: https://github.com/apache/spark/pull/25766#discussion_r323676315
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -1353,19 +1370,17 @@ object CodeGenerator extends Logging {
byteCodeSize
}
}
- Some(stats)
+ (classCodeSize, methodCodeSizes.max, constPoolSize)
} catch {
case NonFatal(e) =>
logWarning("Error calculating stats of compiled class.", e)
- None
+ (classCodeSize, -1, -1)
}
- }.flatten
-
- if (codeSizes.nonEmpty) {
- codeSizes.max
- } else {
- 0
}
+
+ ByteCodeStats(codeStats.reduce[(Int, Int, Int)] { case (v1, v2) =>
+ (Math.max(v1._1, v2._1), Math.max(v1._2, v2._2), Math.max(v1._3, v2._3))
Review comment:
I like this direction.
May we see these values regarding different classes? Is it better to show
class name and method name, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
