srowen commented on a change in pull request #25769: [SPARK-29032][CORE] Add
PrometheusServlet to monitor Master/Worker/Driver
URL: https://github.com/apache/spark/pull/25769#discussion_r323833503
##########
File path: core/src/main/scala/org/apache/spark/metrics/MetricsConfig.scala
##########
@@ -43,6 +43,12 @@ private[spark] class MetricsConfig(conf: SparkConf) extends
Logging {
prop.setProperty("*.sink.servlet.path", "/metrics/json")
prop.setProperty("master.sink.servlet.path", "/metrics/master/json")
prop.setProperty("applications.sink.servlet.path",
"/metrics/applications/json")
+
+ prop.setProperty("*.sink.prometheusServlet.class",
Review comment:
Per your comment below -- OK so these things aren't active unless configured
explicitly. That seems fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
