srowen commented on a change in pull request #25770: [SPARK-29064][CORE] Add
PrometheusResource to export Executor metrics
URL: https://github.com/apache/spark/pull/25770#discussion_r323852556
##########
File path: core/src/main/scala/org/apache/spark/internal/config/UI.scala
##########
@@ -81,6 +81,12 @@ private[spark] object UI {
.booleanConf
.createWithDefault(true)
+ val UI_PROMETHEUS_ENABLED = ConfigBuilder("spark.ui.prometheus.enabled")
Review comment:
Is it possible to simply use the existence of the metrics config, as in your
other PR, to decide whether to enable it? I'd rather not introduce another flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
