Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/731#issuecomment-71668139
Hi, @andrewor14 , thanks for the review, I just addressed your comments
except the one about merging startMultiExecutor/startSingleExecutor
I think the key difference here is that, we want to make start multiple
executors per worker as an application specific option, or a global option
(like spreadApp)
if the former one, I guess I can find some way to merge these two functions
. if the latter one, we truly need an additional spark.* system properties
passed to master's SparkConf, since in schedule() function we cannot get the
application specific "spark.executor.maxCoreNumPerExecutor"... your thoughts?
(I guess I add to rename the configuration entries to spark.deploy.*...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
