dongjoon-hyun commented on a change in pull request #25772:
[SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark
URL: https://github.com/apache/spark/pull/25772#discussion_r324239487
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/ExtractBenchmark.scala
##########
@@ -31,52 +36,76 @@ import java.time.Instant
* Results will be written to "benchmarks/ExtractBenchmark-results.txt".
* }}}
*/
-object ExtractBenchmark extends SqlBasedBenchmark {
+object ExtractBenchmark extends BenchmarkBase with SQLHelper {
+ private val spark: SparkSession = SparkSession.builder()
+ .master("local[1]")
+ .appName(this.getClass.getCanonicalName)
+ .getOrCreate()
Review comment:
Maybe later. For now, never mind. We have more important things to do~
3.0.0-preview is coming! 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
