dongjoon-hyun commented on a change in pull request #25709:
[SPARK-29007][STREAMING][MLLIB][TESTS] Enforce not leaking SparkContext in
tests which creates new StreamingContext with new SparkContext
URL: https://github.com/apache/spark/pull/25709#discussion_r324309877
##########
File path: mllib/pom.xml
##########
@@ -55,6 +55,13 @@
<artifactId>spark-streaming_${scala.binary.version}</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-streaming_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
Review comment:
Ur, this duplicates the existing line 119 and 125 and maven complains due to
this. I'll make a follow-up~
```
~/P/S/mllib:master$ mvn clean package -DskipTests
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model
for org.apache.spark:spark-mllib_2.12:jar:3.0.0-SNAPSHOT
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
must be unique:
org.apache.spark:spark-streaming_${scala.binary.version}:test-jar -> duplicate
declaration of version ${project.version} @ line 119, column 17
[WARNING]
[WARNING] It is highly recommended to fix these problems because they
threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support
building such malformed projects.
[WARNING]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
