holdenk commented on a change in pull request #25748: [SPARK-28904][KUBERNETES]
Create mount for PvTestSuire
URL: https://github.com/apache/spark/pull/25748#discussion_r324341126
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PVTestsSuite.scala
##########
@@ -42,23 +48,14 @@ private[spark] trait PVTestsSuite { k8sSuite:
KubernetesSuite =>
.withKind("PersistentVolume")
.withApiVersion("v1")
.withNewMetadata()
- .withName("test-local-pv")
+ .withName(PV_NAME)
.endMetadata()
.withNewSpec()
.withCapacity(Map("storage" -> new
QuantityBuilder().withAmount("1Gi").build()).asJava)
.withAccessModes("ReadWriteOnce")
.withPersistentVolumeReclaimPolicy("Retain")
- .withStorageClassName("test-local-storage")
- .withLocal(new LocalVolumeSourceBuilder().withPath(VM_PATH).build())
- .withNewNodeAffinity()
- .withNewRequired()
- .withNodeSelectorTerms(new NodeSelectorTermBuilder()
- .withMatchExpressions(new NodeSelectorRequirementBuilder()
- .withKey("kubernetes.io/hostname")
- .withOperator("In")
- .withValues("minikube", "docker-for-desktop",
"docker-desktop").build()).build())
Review comment:
I'm saying this test is already excluded from non-minikube tests so I'm not
adding an exclusion. But I'm happy to leave an JIRA (
https://issues.apache.org/jira/browse/SPARK-29076 ) to explore what would be
needed to remove the minikube only restriction for this test. I don't think it
belongs as a TODO in the code though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
